On Mon, 6 Nov 2023 at 09:56, Victor Shih <victorshihgli@xxxxxxxxx> wrote: > > On Fri, Nov 3, 2023 at 6:28 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > > > > On Fri, 3 Nov 2023 at 11:13, Victor Shih <victorshihgli@xxxxxxxxx> wrote: > > > > > > Hi, Ulf > > > > > > Please help review this patch and give me some advice. > > > I look forward to your reply. > > > > > > Thanks, Victor Shih > > > > I don't have in-depth knowledge of how to properly solve this for pci, > > so I am relying on Kai and others to help review. > > > > Hi, Ulf > > This is a standalone patch, this patch only solves the warning > messages that will > often appear in the system log when the system accesses the GL975x PCI config. > > As I discussed with Kai-Heng at the end of > [V1] mmc: sdhci-pci-gli: GL975[05]: Mask the replay timer timeout of AER, > Kai-Heng will be submitting a patch for the PCIe layer to solve the > situation he encountered. > I will also help Kai-Heng test when he submits the patch. > > Thanks, Victor Shih Hi Victor, I was just about to apply the patch for my fixes branch, when I realized that it would be better to split it up in two patches. One patch for GL9755 and another for GL9750. In this way we can easier manage the back-porting to older stable kernels. The patch for GL9755 should have the below fixes tag: Fixes: 36ed2fd32b2c ("mmc: sdhci-pci-gli: A workaround to allow GL9755 to enter ASPM L1.2") The patch for GL9750 should have the below fixes tag: Fixes: d7133797e9e1 ("mmc: sdhci-pci-gli: A workaround to allow GL9750 to enter ASPM L1.2") I think you should feel free to keep Adrian's and Kai's acks for both of the two new patches, as the end result should end up being the same. [...] Kind regards Uffe