On Tue, 31 Jan 2023 at 09:47, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > If we enable the MMC/SD block layer, use Kconfig to imply the BFQ > I/O scheduler. > > As all MMC/SD devices are single-queue, this is the scheduler that > users want so let's be helpful and make sure it gets > default-selected into a manual kernel configuration. It will still > need to be enabled at runtime (usually with udev scripts). > > Cc: linux-block@xxxxxxxxxxxxxxx > Cc: Paolo Valente <paolo.valente@xxxxxxxxxx> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> I have taken the various arguments (for and against), but I think $subject patch makes sense to me. In the end, this is about moving towards a more sensible default kernel configuration and the "imply" approach works fine for me. More importantly, $subject patch doesn't really hurt anything, as it's still perfectly fine to build MMC without I/O schedulers and BFQ, for those configurations that need this. That said, applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/core/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/core/Kconfig b/drivers/mmc/core/Kconfig > index 6f25c34e4fec..52fe9d7c21cc 100644 > --- a/drivers/mmc/core/Kconfig > +++ b/drivers/mmc/core/Kconfig > @@ -37,6 +37,7 @@ config PWRSEQ_SIMPLE > config MMC_BLOCK > tristate "MMC block device driver" > depends on BLOCK > + imply IOSCHED_BFQ > default y > help > Say Y here to enable the MMC block device driver support. > -- > 2.34.1 >
