On Wed, Feb 1, 2023 at 2:19 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > > diff --git a/drivers/mmc/core/Kconfig b/drivers/mmc/core/Kconfig > > index 6f25c34e4fec..52fe9d7c21cc 100644 > > --- a/drivers/mmc/core/Kconfig > > +++ b/drivers/mmc/core/Kconfig > > @@ -37,6 +37,7 @@ config PWRSEQ_SIMPLE > > config MMC_BLOCK > > tristate "MMC block device driver" > > depends on BLOCK > > + imply IOSCHED_BFQ > > As with most other uses of 'imply', this one does not do what you > think it does. Enabling MMC_BLOCK in 'make menuconfig' or similar > won't actually turn on IOSCHED_BFQ implicitly. The only difference > this makes is that it gets enabled in a 'make defconfig' run when > IOSCHED_BFQ is not already configured. Incidentally that is all I do in my life, so it works as expected for me... but OK. > Just put it into the defconfig files instead. Given that ARMv7 and ARM64/aarch64 often has MMC/SD-cards I suppose I will start sending patches for these. I see that m68k, MIPS Loongson, sh, um and s390 (!!) has already enabled it in their defconfigs. Yours, Linus Walleij
