On 19/01/2023 7:55 UTC, Krzysztof Kozlowski wrote: >On 19/01/2023 04:51, Brad Larson wrote: >> The AMD Pensando Elba SoC has integrated the DW APB SPI Controller >> ... >> .../devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >> index d33b72fabc5d..96b072835de0 100644 >> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml >> @@ -37,6 +37,18 @@ allOf: >> else: >> required: >> - interrupts >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: amd,pensando-elba-spi >> + then: >> + properties: >> + amd,pensando-elba-syscon: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + description: AMD Pensando Elba SoC system controller > >And nothing here - neither in commit msg nor here - explains why do you >need it and what is it for. Adding property amd,pensando-elba-syscon was a result of this thread: https://lore.kernel.org/lkml/20220621101159.stvan53rvr6qugna@mobilestation/ >Define properties in top level "properties:" and here only allow (: >true) or disallow (: false) them. Ok, will change this if the syscon property remains. >> + required: >> + - amd,pensando-elba-syscon >> >> properties: >> compatible: >> @@ -63,6 +75,8 @@ properties: >> const: intel,keembay-ssi >> - description: Intel Thunder Bay SPI Controller >> const: intel,thunderbay-ssi >> + - description: AMD Pensando Elba SoC SPI Controller >> + const: amd,pensando-elba-spi >> - description: Baikal-T1 SPI Controller >> const: baikal,bt1-ssi >> - description: Baikal-T1 System Boot SPI Controller Regards, Brad
