Re: [PATCH 11/14] mmc: tmio_mmc_core: Remove local_irq_{save,restore}() around k[un]map_atomic()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 05, 2022 at 01:19:48PM +0300, Adrian Hunter wrote:
> A long time ago the kmap_atomic API required a slot to be provided which
> risked the possibility that other code might use the same slot at the
> same time. Disabling interrupts prevented the possibility of an interrupt
> handler doing that. However, that went away with
> commit 3e4d3af501cc ("mm: stack based kmap_atomic()").
> 
> When the second argument to kmap_atomic was removed by commit 482fce997e14
> ("mmc: remove the second argument of k[un]map_atomic()"),
> local_irq_{save,restore}() should have been removed also.
> 
> Remove it now.
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

Thank you for cleaning this cruft! Looks good.

Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

I should be able to set up a board for testing this week as well.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux