On Thu, 13 Oct 2022 at 11:44, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > > On Thu, Oct 13, 2022 at 11:32:48AM +0200, Sascha Hauer wrote: > > The core issues the warning "drop HS400 support since no 8-bit bus" when > > one of the ESDHC_FLAG_HS400* flags is set on a non 8bit capable host. To > > avoid this warning set these flags only on hosts that actually can do > > 8bit, i.e. have bus-width = <8> set in the device tree. > > > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > --- > > drivers/mmc/host/sdhci-esdhc-imx.c | 14 ++++++++------ > > 1 file changed, 8 insertions(+), 6 deletions(-) > > Forgot to pass --notes to git send email, so adding this here: > > An alternative approach would be to just lower the warning message > to debug level. In the end it's nice from the core to take the load > from the drivers, if only the core wouldn't complain about it. So I don't recall why we picked the warning level, but maybe the idea was that it should become clear that it's the wrong configuration. On the other hand, that works well with the debug level too. So, why not do both $subject patch and what you propose here? Kind regards Uffe
