On Tue, 19 Jul 2022 at 11:52, Liang He <windhl@xxxxxxx> wrote:
>
> In thunder_mmc_probe(), we should call of_node_put() when breaking
> out of for_each_child_of_node() which has increased and decreased
> the refcount during each iteration.
>
> Fixes: 166bac38c3c5 ("mmc: cavium: Add MMC PCI driver for ThunderX SOCs")
> Signed-off-by: Liang He <windhl@xxxxxxx>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/cavium-thunderx.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cavium-thunderx.c b/drivers/mmc/host/cavium-thunderx.c
> index 76013bbbcff3..202b1d6da678 100644
> --- a/drivers/mmc/host/cavium-thunderx.c
> +++ b/drivers/mmc/host/cavium-thunderx.c
> @@ -142,8 +142,10 @@ static int thunder_mmc_probe(struct pci_dev *pdev,
> continue;
>
> ret = cvm_mmc_of_slot_probe(&host->slot_pdev[i]->dev, host);
> - if (ret)
> + if (ret) {
> + of_node_put(child_node);
> goto error;
> + }
> }
> i++;
> }
> --
> 2.25.1
>
