On Tue, 19 Jul 2022 at 11:10, Liang He <windhl@xxxxxxx> wrote:
>
> In mmc_fixup_of_compatible_match(), we should call of_node_put()
> when breaking out of for_each_child_of_node() which will increase
> and decrease the refcount during one iteration.
>
> Fixes: b360b1102670 ("mmc: core: allow to match the device tree to apply quirks")
> Signed-off-by: Liang He <windhl@xxxxxxx>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/core/quirks.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
> index f879dc63d936..be4393988086 100644
> --- a/drivers/mmc/core/quirks.h
> +++ b/drivers/mmc/core/quirks.h
> @@ -163,8 +163,10 @@ static inline bool mmc_fixup_of_compatible_match(struct mmc_card *card,
> struct device_node *np;
>
> for_each_child_of_node(mmc_dev(card->host)->of_node, np) {
> - if (of_device_is_compatible(np, compatible))
> + if (of_device_is_compatible(np, compatible)) {
> + of_node_put(np);
> return true;
> + }
> }
>
> return false;
> --
> 2.25.1
>
