On Wed, Jul 6, 2022 at 2:52 AM Chanwoo Lee <cw9316.lee@xxxxxxxxxxx> wrote: > From: ChanWoo Lee <cw9316.lee@xxxxxxxxxxx> > > SD_ROCR_S18A is already defined > and is used to check the rocr value as shown below. > > So, replace with already defined values for readability. > > -------------------------------------------------- > /sd.h > .#define SD_OCR_S18R (1 << 24) /* 1.8V switching request */ > .#define SD_ROCR_S18A SD_OCR_S18R /* 1.8V switching accepted by card */ > > /sd.c > static int mmc_sd_init_card(struct mmc_host *host, u32 ocr, > struct mmc_card *oldcard) > { > ... > if (rocr & SD_ROCR_S18A && mmc_host_uhs(host)) { > err = mmc_sd_init_uhs_card(card); > } > ------------------------------------------------- > > Signed-off-by: ChanWoo Lee <cw9316.lee@xxxxxxxxxxx> Excellent patch. Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij