On Thu, Apr 07, 2022 at 08:52:34PM +0200, Krzysztof Kozlowski wrote: > On 07/04/2022 01:36, Brad Larson wrote: > > The Pensando Elba SoC has integrated the DW APB SPI Controller > > and requires the property pensando,syscon-spics for access > > to the spics control register. > > > > Signed-off-by: Brad Larson <brad@xxxxxxxxxxx> > > --- > > Change from V3: > > - Add required property pensando,syscon-spics to go with > > pensando,elba-spi > > Thank you for your patch. There is something to discuss/improve. > > > > .../bindings/spi/snps,dw-apb-ssi.yaml | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > index d7e08b03e204..41c3bbf5a55c 100644 > > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > @@ -37,6 +37,21 @@ allOf: > > else: > > required: > > - interrupts > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - pensando,elba-spi > > + then: > > + properties: > > + pensando,syscon-spics: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to the system control device node which provides access to > > + the spics control register > > It looks you only need to poke one register from spics, so it could be > something like: > > items: > - items: > - description: Phandle to the system control device node > - description: spics control register offset Right, especially seeing that's the way the elba-specific part of the DW APB SSI driver expects the property being initialized. -Sergey > > > Best regards, > Krzysztof
