On Mon, 9 Aug 2021 at 13:17, A, Rashmi <rashmi.a@xxxxxxxxx> wrote: > > > > > -----Original Message----- > > From: Vinod Koul <vkoul@xxxxxxxxxx> > > Sent: Monday, August 9, 2021 2:12 PM > > To: A, Rashmi <rashmi.a@xxxxxxxxx> > > Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>; Michal Simek > > <michal.simek@xxxxxxxxxx>; linux-mmc <linux-mmc@xxxxxxxxxxxxxxx>; Linux > > ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux- > > kernel@xxxxxxxxxxxxxxx>; Kishon <kishon@xxxxxx>; Andy Shevchenko > > <andriy.shevchenko@xxxxxxxxxxxxxxx>; linux-phy@xxxxxxxxxxxxxxxxxxx; Mark > > Gross <mgross@xxxxxxxxxxxxxxx>; kris.pan@xxxxxxxxxxxxxxx; Zhou, Furong > > <furong.zhou@xxxxxxxxx>; Sangannavar, Mallikarjunappa > > <mallikarjunappa.sangannavar@xxxxxxxxx>; Hunter, Adrian > > <adrian.hunter@xxxxxxxxx>; Vaidya, Mahesh R > > <mahesh.r.vaidya@xxxxxxxxx>; Srikandan, Nandhini > > <nandhini.srikandan@xxxxxxxxx>; Demakkanavar, Kenchappa > > <kenchappa.demakkanavar@xxxxxxxxx> > > Subject: Re: [PATCH 2/3] mmc: sdhci-of-arasan: Add intel Thunder Bay SOC > > support to the arasan eMMC driver > > > > On 09-08-21, 05:16, A, Rashmi wrote: > > > > > > > > > > Rashmi, is it safe to apply this separately from the phy driver/dt changes? > > > > Then I can queue this via my mmc tree, if you like. > > > No, the phy driver/dt changes must go together with "mmc: sdhci-of- > > arasan: Add intel Thunder Bay SOC support to the arasan eMMC driver" > > patch. > > > > Why is that? > > > > What could happen, emmc driver will complain about phy not found and bail > > right? > This is right, but ideally both mmc:phy and mmc: sdhci-of-arasan driver code changes should go together If patches are well written and can be standalone, we (maintainers) ideally prefer to queue things on a per subsystem basis, because it's just easier. That said, I also noticed that a new compatible string was added, "intel,thunderbay-sdhci-5.1". This needs to be documented in Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml, in a separate patch, preceding $subject patch. Kind regards Uffe
