On 29/12/20 10:46 am, Jisheng Zhang wrote: > Hi, > > Two patch series: > > *emmc inline encryption > Recently Eric sent out emmc inline encryption patches, per my understanding > the emmc inline encryption based on CQ interface:cqhci. > > *ADMA3 support > Baolin send out ADMA3 support patches: https://lkml.org/lkml/2020/4/26/125 > which makes use of the ADMA3 transfer in mmc software queue. > > Per my understanding, ADMA3 is focusing on the host side while the emmc CQ > focuses on emmc card side, they don't conflict with each other. But current > mmc_blk_cqe_issue_rw_rq() goes through either hsq or cqe code path but not both. > > So how can ADMA3 and CQE be used at the same time? > > Thanks in advance > The mmc block driver has a CQE *interface* based around struct mmc_cqe_ops, which was designed for JEDEC eMMC CQHCI. CQHCI is a host side hardware command queue engine and it now supports hardware inline encryption. CQHCI can only be used with eMMCs that support command queuing. The mmc block driver CQE interface was later also adopted for a software based queue called hsq. hsq does not support eMMC command queuing. Command queuing is an eMMC card feature. It does not require CQHCI although that is all we support at the moment. ADMA3 is a hardware host-side interface that conflicts with CQHCI. ADMA3 can be used with both SD cards and eMMC and does not require that a card supports command queuing.
