Hi Ulf,
On Wed, Nov 25, 2020 at 6:49 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>
> On Wed, 25 Nov 2020 at 11:43, Ben Chuang <benchuanggli@xxxxxxxxx> wrote:
> >
> > Hi Ulf,
> >
> > On Wed, Nov 25, 2020 at 6:04 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> > >
> > > On Wed, 25 Nov 2020 at 10:59, Ben Chuang <benchuanggli@xxxxxxxxx> wrote:
> > > >
> > > > From: Ben Chuang <ben.chuang@xxxxxxxxxxxxxxxxxxx>
> > > >
> > > > The GL9763E uses 150Mhz (slow mode) by default in HS400 mode. In order
> > > > to make HS400 mode run at 200Mhz, the slow mode needs to be turned off.
> > > >
> > > > Fixes: 1ae1d2d6e555 ("mmc: sdhci-pci-gli: Add Genesys Logic GL9763E support")
> > >
> > > Why a fixes tag? This patch looks like an improvement and not a fix, right?
> > >
> >
> > Since the specification defines that the HS400 mode must run at 200Mhz,
> > this patch fixes the HS400 mode to 200Mhz.
>
> The spec states that in HS400 mode the clock can be *up to 200MHz* -
> not that it must run at 200MHz. At least at those places I have looked
> at in the spec.
>
You are right. I will resend v2.
Best regards,
Ben
> [...]
>
> Kind regards
> Uffe
