On Thu, Oct 8, 2020 at 1:36 PM Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@xxxxxxxxx> wrote: > >From: Michal Simek <michal.simek@xxxxxxxxxx> > >Sent: Thursday, October 8, 2020 3:35 PM > >On 08. 10. 20 4:09, muhammad.husaini.zulkifli@xxxxxxxxx wrote: > >> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@xxxxxxxxx> ... > >> @@ -1521,6 +1521,7 @@ static int sdhci_arasan_probe(struct > >platform_device *pdev) > >> struct sdhci_pltfm_host *pltfm_host; > >> struct sdhci_arasan_data *sdhci_arasan; > >> struct device_node *np = pdev->dev.of_node; > >> + struct device *dev = &pdev->dev; > >> const struct sdhci_arasan_of_data *data; > >> > >> match = of_match_node(sdhci_arasan_of_match, pdev->dev.of_node); > >> > > > >This is not what we discussed. You create new variable and you should just use it > >in that function. > > > >s/pdev->dev\./dev->/g > > For widely used in future, we plan to put it here and not specific to Keembay function only. > Any comment on this @Andy Shevchenko? I'm not sure what comment from me is needed. I'm on the same page with Michal, i.e. replace current users of &pdev->dev with a new temporary variable. -- With Best Regards, Andy Shevchenko
