Hi Andy, Thanks for the feedback. >-----Original Message----- >From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> >Sent: Thursday, October 8, 2020 4:46 PM >To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@xxxxxxxxx> >Cc: Hunter, Adrian <adrian.hunter@xxxxxxxxx>; Michal Simek ><michal.simek@xxxxxxxxxx>; Shevchenko, Andriy ><andriy.shevchenko@xxxxxxxxx>; Ulf Hansson <ulf.hansson@xxxxxxxxxx>; linux- >mmc <linux-mmc@xxxxxxxxxxxxxxx>; linux-arm Mailing List <linux-arm- >kernel@xxxxxxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux- >kernel@xxxxxxxxxxxxxxx>; Raja Subramanian, Lakshmi Bai ><lakshmi.bai.raja.subramanian@xxxxxxxxx>; Wan Mohamad, Wan Ahmad Zainie ><wan.ahmad.zainie.wan.mohamad@xxxxxxxxx>; Arnd Bergmann ><arnd@xxxxxxxx> >Subject: Re: [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted >Firmware Service call > >On Thu, Oct 8, 2020 at 5:48 AM <muhammad.husaini.zulkifli@xxxxxxxxx> wrote: >> >> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@xxxxxxxxx> >> >> Add header file to handle API function for device driver to >> communicate with Arm Trusted Firmware. > >Arm -> ARM ? I will rename based on Sudeep's mentioned in latest thread > >... > >> .../linux/firmware/intel/keembay_firmware.h | 47 +++++++++++++++++++ > >Please, drop dup of 'firmware' in the filename. Noted. Will change to keembay.h > >... > >> +/* >> + * Intel Keembay SOC Firmware API Layer >> + * > >> + * Copyright (C) 2020-2021, Intel Corporation > >Hello from the future? > Will edit to Copyright (C) 2020, Intel Corporation >> + * >> + * Muhammad Husaini Zulkifli <Muhammad.Husaini.Zulkifli@xxxxxxxxx> > >Author: ... > >> + */ > >... > >> +/* >> + * This file defines API function that can be called by device driver >> +in order to > >an API >by a device Noted 😊 > >> + * communicate with Arm Trusted Firmware. > >Arm -> ARM ? I will rename based on Sudeep's mentioned in latest thread > >> + */ > >-- >With Best Regards, >Andy Shevchenko
