On Thu, Oct 8, 2020 at 5:48 AM <muhammad.husaini.zulkifli@xxxxxxxxx> wrote: > > From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@xxxxxxxxx> > > Add header file to handle API function for device driver to communicate > with Arm Trusted Firmware. Arm -> ARM ? ... > .../linux/firmware/intel/keembay_firmware.h | 47 +++++++++++++++++++ Please, drop dup of 'firmware' in the filename. ... > +/* > + * Intel Keembay SOC Firmware API Layer > + * > + * Copyright (C) 2020-2021, Intel Corporation Hello from the future? > + * > + * Muhammad Husaini Zulkifli <Muhammad.Husaini.Zulkifli@xxxxxxxxx> Author: ... > + */ ... > +/* > + * This file defines API function that can be called by device driver in order to an API by a device > + * communicate with Arm Trusted Firmware. Arm -> ARM ? > + */ -- With Best Regards, Andy Shevchenko