Hi Angelo,
On 25/5/20 6:51 pm, Angelo Dureghello wrote:
Hi Greg,
On Mon, May 25, 2020 at 8:02 AM Greg Ungerer <gerg@xxxxxxxxxxxxxx> wrote:
Hi Angelo,
Have you seen this breakage being reported in linux-next?
arch/m68k/coldfire/clk.c:78:60: error: 'MCFSDHC_CLK' undeclared (first
use in this function); did you mean 'MCF_CLK'?
arch/m68k/coldfire/clk.c:83:61: error: 'MCFSDHC_CLK' undeclared (first
use in this function); did you mean 'MCF_CLK'?
make[2]: *** [scripts/Makefile.build:272: arch/m68k/coldfire/clk.o]
Error 1
make[1]: *** [Makefile:1736: arch/m68k/coldfire] Error 2
make: *** [Makefile:185: __sub-make] Error 2
This is when compiling for pretty much anything other than an mcf5441x
target.
MCFSDHC_CLK will not be defiend for anything other than mcf5441x targets.
This mechanism looks a little out of place here, given how specific
it is to the sdhc hardware module of the 5441x. Can you move this
to the m5441x specific code resolving this?
i apologize. Couldn't catch that since building for this target.
Fixing, re-testing and sending patch in short.
There is a bunch of default ColdFire target configurations in
arch/m68k/configs/M* that you can test compile for. Gives you
pretty good coverage across various ColdFire types.
Regards
Greg
