On 19/05/20 1:42 pm, Y.b. Lu wrote:
> Hi Uffe and Adrian,
>
>
>
> May I have a query on below patch. Do we really need re-tuning before
> switching to RPMB partition each time per eMMC spec, especially for HS400
> mode with auto-tuning?
It was to ensure tuning would not be needed while accessing RPMB since RPMB
does not support tuning.
>
> What’s the impact if no re-tuning here?
Increased risk of CRC errors.
>
>
>
> 7ff2760 mmc: core: Add a facility to "pause" re-tuning
>
>
>
> +/*
>
> + * Pause re-tuning for a small set of operations. The pause begins after the
>
> + * next command and after first doing re-tuning.
>
> + */
>
> +void mmc_retune_pause(struct mmc_host *host)
>
> +{
>
> + if (!host->retune_paused) {
>
> + host->retune_paused = 1;
>
> + mmc_retune_needed(host);
>
> + mmc_retune_hold(host);
>
> + }
>
> +}
>
>
>
> Thanks a lot.
>
>
>
> Best regards,
>
> Yangbo Lu
>
>
>
