On Tue, 19 May 2020 at 18:38, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, May 19, 2020 at 05:24:45PM +0200, Ulf Hansson wrote: > > If the tmio device is attached to a genpd (PM domain), that genpd may have > > ->start|stop() callback assigned to it. To make sure the device is > > accessible during ->probe(), genpd's ->start() callback must be invoked, > > which is currently managed by tmio_mmc_host_probe(). However, it's likely > > that may be too late for some cases, as registers may be read and written > > way before that point. > > > > To fix the behaviour, let's move the call to dev_pm_domain_start() from > > tmio_mmc_host_probe() into those clients that needs it. From discussions at > > linux-mmc mailing list, it turned out that it should be sufficient to do > > this for the SDHI renesas variants, hence the call is move to > > renesas_sdhi_probe(). > > > > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > > Rebind works on my Salvator-XS board (M3-N) and my Lager board (H2). No > other issues found when booting and accessing SD cards or eMMC. > > Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > Tested-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > Thanks, Ulf! > Applied for next! Kind regards Uffe
