RE: [EXT] RE: [PATCH] mmc-utils: enable CMD25 as optional for FFU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >
> > >
> > > As per specification, the host can use either CMD24 or CMD25 for the
> > > FFU. CMD25 is better option as it can program the firmware image in one
> > > go.
> > >
> > > CMD25 is enabled as optional and user can use this by giving optional
> > > parameter '-c'.
> > > Example: mmc ffu -c <firmware_image> <device>
> > >
> > > Signed-off-by: Shivamurthy Shastri <sshivamurthy@xxxxxxxxxx>
> > Why make it optional?
> 
> I was not sure about the reason behind using CMD24 instead of CMD25.
> 
> > If you indeed see a considerable performance gain, just use cmd25 instead.
> > Can you share those improvement rates that you noticed while testing?
> 
> The code is like below:
> 
> clock_gettime(CLOCK_REALTIME, &start);
> while (chunk_size > 0) {
> ...
> }
> clock_gettime(CLOCK_REALTIME, &end);
> .....
> 
> In the case of CMD24 completion took 635msec and in the case of CMD25
> completion took 20msec.
Wow - Impressive....
Did you tried running it close-ended as well?

Please send a V2 without the -c, I will review it.

Thanks,
Avri





[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux