On Mon, Nov 26, 2018 at 9:39 AM Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > + status = mmc_gpiod_request_cd(mmc, NULL, 0, false, 1, NULL); > > As for patch 02/11, shouldn't the override argument be set to true ? (...) > > + status = mmc_gpiod_request_ro(mmc, NULL, 1, false, 0, NULL); > > Same here. Oh after looking, actually not. Since I also fix up all the descriptors in this patch to actually indicate the right polarity, we do not need to override it, the setting in the descriptor is correct. Yours, Linus Walleij
