On Mon, Nov 26, 2018 at 9:39 AM Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > On Monday, 26 November 2018 00:52:07 EET Linus Walleij wrote: > It would be nice to update the mmc-spi-slot bindings to use cd-gpios and wp- > gpios (of course keeping backward compatibility on the driver side). Yeah it'd be nice, however I am just dry-coding this right now. I had a Sim.One board before but it broke, I am talking to the vendor trying to get a new one. I think I need some hardware for deeper semantic changes. > > + status = mmc_gpiod_request_cd(mmc, NULL, 0, false, 1, NULL); > > As for patch 02/11, shouldn't the override argument be set to true ? (...) > > + status = mmc_gpiod_request_ro(mmc, NULL, 1, false, 0, NULL); > > Same here. OK > Apart from that, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Thanks! > Please note that I don't have any of the boards above, so I haven't been able > to test the changes. Hm none of the maintainers seems to be using the Ecovec board... Yours, Linus Walleij
