Hi Avri, With On Tue, 20 Nov 2018 at 07:48, Avri Altman <Avri.Altman@xxxxxxx> wrote: > > > Well, in such case there is likely a bug in the mmc host driver, which > > we need to fix. > > > > In either case, I think we should move forward with your suggested > > patch. If any additional things are needed on top, then let's fix them > > as well. > I don't think that this could no longer happen on modern kernels (was observed on V4.9), > Because mmc_blk_alloc_rpmb_part will not be called for the reasons you specified, > So there is no mmcblk0rpmb, and idata->rpmb is null for all other devices. I would like to confirm this and did some test on 4.14.81 with a sdhci-iproc controller / MMC_MULTI_CMD in mmc_utils. But the read-counter doesn't seems to work : in 4.14 : # uname -a Linux 192.168.1.219 4.14.81 #1 SMP PREEMPT Tue Nov 20 15:14:36 CET 2018 armv7l GNU/Linux # date Tue Nov 20 14:19:28 UTC 2018 # mmc rpmb read-counter /dev/mmcblk0rpmb Counter value: 0x7085de01 # mmc rpmb read-counter /dev/mmcblk0rpmb Counter value: 0x70f56201 # mmc rpmb read-counter /dev/mmcblk0rpmb Counter value: 0x70a59301 # mmc rpmb read-counter /dev/mmcblk0rpmb Counter value: 0x70752301 whereas in 4.9: # mmc rpmb read-counter /dev/mmcblk0rpmb Counter value: 0x000001d0 # mmc rpmb read-counter /dev/mmcblk0rpmb Counter value: 0x000001d0 # mmc rpmb read-counter /dev/mmcblk0rpmb Counter value: 0x000001d0 # mmc rpmb read-counter /dev/mmcblk0rpmb Counter value: 0x000001d0 # mmc rpmb read-counter /dev/mmcblk0rpmb Counter value: 0x000001d0 # mmc rpmb read-counter /dev/mmcblk0rpmb Counter value: 0x000001d0 > > Thanks, > Avri
