On 25 June 2018 at 10:46, Yinbo Zhu <yinbo.zhu@xxxxxxx> wrote: > From: yinbo.zhu <yinbo.zhu@xxxxxxx> > > Convert to use of_match_node method to fix up eSDHC clock for > ls1046a/ls1012a/p1010. Also add eSDHC clock fixup for ls1021a > according to its datasheet. The maxmum speed for ls1021a eSDHC > high speed mode is 46.5MHz. > > Signed-off-by: Yinbo Zhu <yinbo.zhu@xxxxxxx> Thanks, applied for next! Although, please have a look at below comment. [...] > + > +static const struct of_device_id sdhci_esdhc_of_match[] = { > + { .compatible = "fsl,ls1021a-esdhc", .data = &ls1021a_esdhc_clk}, > + { .compatible = "fsl,ls1046a-esdhc", .data = &ls1046a_esdhc_clk}, > + { .compatible = "fsl,ls1012a-esdhc", .data = &ls1012a_esdhc_clk}, > + { .compatible = "fsl,p1010-esdhc", .data = &p1010_esdhc_clk}, > + { .compatible = "fsl,mpc8379-esdhc" }, > + { .compatible = "fsl,mpc8536-esdhc" }, > + { .compatible = "fsl,esdhc" }, > + { } [...] It turned out that some of these compatibles aren't document, but still being used already today. Would you mind posting a patch fixing the DT docs for these? [...] Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html