On 2018/5/23 17:21, Yinbo Zhu wrote:
-----Original Message-----
From: Shawn Lin [mailto:shawn.lin@xxxxxxxxxxxxxx]
Sent: 2018年5月23日 14:29
To: Yinbo Zhu <yinbo.zhu@xxxxxxx>; linux-mmc@xxxxxxxxxxxxxxx
Cc: Y.b. Lu <yangbo.lu@xxxxxxx>; Adrian Hunter <adrian.hunter@xxxxxxxxx>; shawn.lin@xxxxxxxxxxxxxx; Xiaobo Xie <xiaobo.xie@xxxxxxx>
Subject: Re: [PATCH] mmc: sd: Macro name cleanup for full speed dtr
On 2018/5/23 11:53, Yinbo Zhu wrote:
Add new macros for the full speed 25MHz case
It is't clear to me what's full speed and why you need this.
Perhaps you could quote some more details from the spec.
In sd/emmc all speed mode, Only it lacks definition in code
And some erratum need it.
The SD spec says it's "Default Speed mode". Then (e)MMC spec doesn't
clearly say what it is but just saying "legacy MMC card", whoes
frequency varis from 0 - 26MHz. So from the patch itself, 25000000
implies you might need to follow the SD spec and call it
"DEFAULT_SPEED_MAX_DXTR".
Regards
Yinbo.
Signed-off-by: Yinbo Zhu <yinbo.zhu@xxxxxxx>
---
include/linux/mmc/card.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h index
279b390..94512ca 100644
--- a/include/linux/mmc/card.h
+++ b/include/linux/mmc/card.h
@@ -156,6 +156,7 @@ struct sd_switch_caps {
#define UHS_DDR50_MAX_DTR 50000000
#define UHS_SDR25_MAX_DTR UHS_DDR50_MAX_DTR
#define UHS_SDR12_MAX_DTR 25000000
+#define FULL_SPEED_MAX_DTR UHS_SDR12_MAX_DTR
unsigned int sd3_bus_mode;
#define UHS_SDR12_BUS_SPEED 0
#define HIGH_SPEED_BUS_SPEED 1
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
