Hi Ulf, On Tue, Apr 03, 2018 at 10:19:02AM +0200, Ulf Hansson wrote: > On 26 March 2018 at 11:06, Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > Hi Ulf, > > > > On Fri, Mar 23, 2018 at 04:37:32PM +0800, kbuild test robot wrote: > >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next > >> head: 4472f0fc248e3f0573301f725eff9dc9cde5cb62 > >> commit: 774c010350a16f44705971e8aff457580628c76e [49/59] mmc: sunxi: Move resources management to separate functions > >> config: arm-allmodconfig (attached as .config) > >> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 > >> reproduce: > >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > >> chmod +x ~/bin/make.cross > >> git checkout 774c010350a16f44705971e8aff457580628c76e > >> # save the attached .config to linux build tree > >> make.cross ARCH=arm > >> > >> Note: the ulf.hansson-mmc/next HEAD 4472f0fc248e3f0573301f725eff9dc9cde5cb62 builds fine. > >> It only hurts bisectibility. > >> > >> All errors (new ones prefixed by >>): > >> > >> drivers/mmc/host/sunxi-mmc.c: In function 'sunxi_mmc_enable': > >> >> drivers/mmc/host/sunxi-mmc.c:1175:11: error: 'dev' undeclared (first use in this function); did you mean 'cdev'? > >> dev_err(dev, "Couldn't enable the bus clocks (%d)\n", ret); > >> ^~~ > >> cdev > >> drivers/mmc/host/sunxi-mmc.c:1175:11: note: each undeclared identifier is reported only once for each function it appears in > >> > >> vim +1175 drivers/mmc/host/sunxi-mmc.c > >> > >> 1168 > >> 1169 static int sunxi_mmc_enable(struct sunxi_mmc_host *host) > >> 1170 { > >> 1171 int ret; > >> 1172 > >> 1173 ret = clk_prepare_enable(host->clk_ahb); > >> 1174 if (ret) { > >> > 1175 dev_err(dev, "Couldn't enable the bus clocks (%d)\n", ret); > > > > This would need to be changed to host->dev. > > Yeah, but it seems like you fixed that in the following commits for > sunxi on top, as my next branch builds just fine. > > Normally I strive to avoid breaking bisect via re-basing my next > branch and dropping offending commits, however, at this point being in > the merge window I don't want to re-base my branch. Thus I have > decided to leave it as is this time. > > Next time, please try to be more careful and build each change > separately. I try to do that as well, but I managed to screw this one up. Sorry :/ Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
