Re: [ulf.hansson-mmc:next 49/59] drivers/mmc/host/sunxi-mmc.c:1175:11: error: 'dev' undeclared; did you mean 'cdev'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ulf,

On Fri, Mar 23, 2018 at 04:37:32PM +0800, kbuild test robot wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next
> head:   4472f0fc248e3f0573301f725eff9dc9cde5cb62
> commit: 774c010350a16f44705971e8aff457580628c76e [49/59] mmc: sunxi: Move resources management to separate functions
> config: arm-allmodconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 774c010350a16f44705971e8aff457580628c76e
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm 
> 
> Note: the ulf.hansson-mmc/next HEAD 4472f0fc248e3f0573301f725eff9dc9cde5cb62 builds fine.
>       It only hurts bisectibility.
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/mmc/host/sunxi-mmc.c: In function 'sunxi_mmc_enable':
> >> drivers/mmc/host/sunxi-mmc.c:1175:11: error: 'dev' undeclared (first use in this function); did you mean 'cdev'?
>       dev_err(dev, "Couldn't enable the bus clocks (%d)\n", ret);
>               ^~~
>               cdev
>    drivers/mmc/host/sunxi-mmc.c:1175:11: note: each undeclared identifier is reported only once for each function it appears in
> 
> vim +1175 drivers/mmc/host/sunxi-mmc.c
> 
>   1168	
>   1169	static int sunxi_mmc_enable(struct sunxi_mmc_host *host)
>   1170	{
>   1171		int ret;
>   1172	
>   1173		ret = clk_prepare_enable(host->clk_ahb);
>   1174		if (ret) {
> > 1175			dev_err(dev, "Couldn't enable the bus clocks (%d)\n", ret);

This would need to be changed to host->dev.

>   1176			return ret;
>   1177		}
>   1178	
>   1179		ret = clk_prepare_enable(host->clk_mmc);
>   1180		if (ret) {
>   1181			dev_err(host->dev, "Enable mmc clk err %d\n", ret);
>   1182			goto error_disable_clk_ahb;
>   1183		}
>   1184	
>   1185		ret = clk_prepare_enable(host->clk_output);
>   1186		if (ret) {
>   1187			dev_err(host->dev, "Enable output clk err %d\n", ret);
>   1188			goto error_disable_clk_mmc;
>   1189		}
>   1190	
>   1191		ret = clk_prepare_enable(host->clk_sample);
>   1192		if (ret) {
>   1193			dev_err(host->dev, "Enable sample clk err %d\n", ret);
>   1194			goto error_disable_clk_output;
>   1195		}
>   1196	
>   1197		if (!IS_ERR(host->reset)) {
>   1198			ret = reset_control_reset(host->reset);
>   1199			if (ret) {
>   1200				dev_err(dev, "Couldn't reset the MMC controller (%d)\n",
>   1201					ret);

And here as well.

What should we do to fix it?

Maxime


-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux