On 6 March 2018 at 13:45, Harish Jenny K N <harish_kandiga@xxxxxxxxxx> wrote: > > > On Monday 05 March 2018 09:02 PM, Ulf Hansson wrote: >> >>>> >>>> >>>> Sorry, but this doesn't work. We may very well be changing the bit >>>> offsets for the caps and caps2 in the mmc kernel header, keeping a >>>> copy of them is not a good idea. It's just a matter of *when* it will >>>> break. >>> >>> I guess we could create a header file under include/uapi? This's how >>> other drivers, for instance, tty, PCI or graphic subsystem to keep user >>> space consistent with kernel side. >> Well, yes, for cases where this about providing a userspace ABI. >> >> This is about debugfs, which don't have this constraint. We may decide >> to break/drop/change any debugfs support, whenever we want. >> >> So, overall, no I don't like it. If this were about the mmc ioctl or >> the sysfs nodes, then yes. > > Can I move the parsing logic to kernel, by creating file using debugfs_create_file for caps and caps2 instead of debugfs_create_x32 ? This would mean no need of parsing in mmc-utils. That seems like a better idea! Although, having one debugs file should be sufficient, just print/parse both caps and caps2 from within then same debugfs function. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
