On 4 January 2018 at 16:30, Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx> wrote: > mmc clock can be stopped during runtime suspend and restart during runtime > resume if the sdio irq is not enabled. Stop sdio clock reduce EMI of > the device when the bus is not in use. > > Signed-off-by: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx> Thanks, applied for next! Adrian, please tell me if you are not happy with this. Kind regards Uffe > --- > Changes V2->V3: > - move clock re-order on a separated patch > > Changes V1->V2: > - rebase to latest linux > - address sdio irq wakeup > - move the clock enable clk_ahb up to be balance > with the runtime suspend function and to make > function more clean by the end without two if > condition > --- > drivers/mmc/host/sdhci-esdhc-imx.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c > index 6d4e323..53cc1b6 100644 > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > @@ -193,6 +193,7 @@ struct pltfm_imx_data { > struct clk *clk_ipg; > struct clk *clk_ahb; > struct clk *clk_per; > + unsigned int actual_clock; > enum { > NO_CMD_PENDING, /* no multiblock command pending */ > MULTIBLK_IN_PROCESS, /* exact multiblock cmd in process */ > @@ -1396,6 +1397,8 @@ static int sdhci_esdhc_runtime_suspend(struct device *dev) > mmc_retune_needed(host->mmc); > > if (!sdhci_sdio_irq_enabled(host)) { > + imx_data->actual_clock = host->mmc->actual_clock; > + esdhc_pltfm_set_clock(host, 0); > clk_disable_unprepare(imx_data->clk_per); > clk_disable_unprepare(imx_data->clk_ipg); > } > @@ -1422,6 +1425,7 @@ static int sdhci_esdhc_runtime_resume(struct device *dev) > err = clk_prepare_enable(imx_data->clk_ipg); > if (err) > goto disable_per_clk; > + esdhc_pltfm_set_clock(host, imx_data->actual_clock); > } > > err = sdhci_runtime_resume_host(host); > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html