Re: [PATCH V2 1/3] mmc: sdhci-esdhc-imx: Manage sdhci_runtime_suspend_host error code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4 January 2018 at 16:30, Michael Trimarchi
<michael@xxxxxxxxxxxxxxxxxxxx> wrote:
> We need to return in case of error even if the actual implementation
> of sdhci_runtime_suspend_host always return 0. We don't want to
> power down the clock and the assuption is that the sdhci_runtime_suspend_host
> always let the system consistent in case of failure
>
> Signed-off-by: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx>

Thanks, applied for next!

Adrian, please tell me if you are not happy with this.

Kind regards
Uffe

> ---
> Changes None
>
> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 85140c9..d08c21e 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -1389,6 +1389,8 @@ static int sdhci_esdhc_runtime_suspend(struct device *dev)
>         int ret;
>
>         ret = sdhci_runtime_suspend_host(host);
> +       if (ret)
> +               return ret;
>
>         if (host->tuning_mode != SDHCI_TUNING_MODE_3)
>                 mmc_retune_needed(host->mmc);
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux