On Mon, Oct 02, 2017 at 10:06:05AM -0700, David Daney wrote: > On 10/02/2017 05:02 AM, Jan Glauber wrote: > >Without the ThunderX/OcteonTx GPIO driver the MMC driver > >would not power up any MMC devices. Therefore add a > >dependency to the GPIO driver and remove the unneeded GPIOLIB > >dependency. > > > >Signed-off-by: Jan Glauber <jglauber@xxxxxxxxxx> > >--- > > drivers/mmc/host/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > >index 8c15637178ff..a47a2f1d8ae4 100644 > >--- a/drivers/mmc/host/Kconfig > >+++ b/drivers/mmc/host/Kconfig > >@@ -663,7 +663,7 @@ config MMC_CAVIUM_OCTEON > > config MMC_CAVIUM_THUNDERX > > tristate "Cavium ThunderX SD/MMC Card Interface support" > > depends on PCI && 64BIT && (ARM64 || COMPILE_TEST) > >- depends on GPIOLIB > >+ depends on GPIO_THUNDERX > > We could just "select" GPIO_THUNDERX instead so that people aren't > forced to manually unwind all the dependencies. I thought about select vs. depends, but the Documentation prefers depends as a select would not automatically enable everything GPIO_THUNDERX needs. See in Documentation/kbuild/kconfig-language.txt the note about select. --Jan > Also, what do we do if the required GPIO lines are on I2C expanders? > This patch doesn't help in this hypothetical case. In the end it is > the responsibility if the system designer to ensure the proper > drivers are available in their kernels. I think the patch is a step > in the right direction, but just wanted to note that it doesn't > cover all possible cases. > > In any event, you can add ...: > > Acked-by: David Daney <david.daney@xxxxxxxxxx> > > ... to either this version, or an alternative patch that does the > "select" instead. > > Thanks > > > > depends on OF_ADDRESS > > help > > This selects Cavium ThunderX SD/MMC Card Interface. > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
