On 21 September 2017 at 10:25, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
> On 21/09/17 08:42, Yangbo Lu wrote:
>> SD clock should be disabled for clock value 0. It's not
>> right to just return. This may cause failure of signal
>> voltage switching.
>>
>> Signed-off-by: Yangbo Lu <yangbo.lu@xxxxxxx>
>
> Minor comment below, nevertheless:
>
> Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
>
>> ---
>> drivers/mmc/host/sdhci-of-esdhc.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
>> index d96a057a7db8..b21008729aeb 100644
>> --- a/drivers/mmc/host/sdhci-of-esdhc.c
>> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
>> @@ -36,6 +36,8 @@ struct sdhci_esdhc {
>> unsigned int peripheral_clock;
>> };
>>
>> +static void esdhc_clock_enable(struct sdhci_host *host, bool enable);
>
> We usually move functions rather than forward declare them.
I agree, can you please re-spin.
[...]
Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
