Re: [PATCH mmc/next v2 2/4] mmc: tmio, renesas-sdhi: add complete to DMA ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 16, 2017 at 11:58:52AM +0200, Simon Horman wrote:
> Add complete to DMA ops to allow DMAC implementation dependent
> handling of DMA completion.
> 
> Also implement the operation for SDHI.
> 
> Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>

Codewise, I am all fine with this patch. There is one naming, however:

> +	void (*complete)(struct tmio_mmc_host *host);

I'd rather call it 'dataend'. For internal DMAC, it is the same. But for
SYS-DMAC there is difference between DATAEND and DMA_COMPLETE. This is
exactly the reason we have commit 52ad9a8e854ca1 ("mmc: tmio: ensure end
of DMA and SD access are in sync").

Basically, something like %s/complete/dataend/g would do it for me...

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux