On 9 June 2017 at 15:23, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Thu, Jun 8, 2017 at 3:27 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > >> The mmc_start_bkops(), mmc_stop_bkops() and mmc_read_bkops_status() >> functions are all specific to eMMCs. To make this clear, let's move them >> from from core.c to mmc_ops.c. >> >> While moving them, get rid of MMC_BKOPS_MAX_TIMEOUT (4 min) and use the >> common default timeout MMC_OPS_TIMEOUT_MS (10 min) instead, as there is no >> need to have specific default timeout for bkops. >> >> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > > Oh then my previous suggestion to mark those static are not > very good. Actually there is v2 of this change, taking into consideration your suggestions of making functions static. > > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Yours, > Linus Walleij Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
