Re: [PATCH 1/9] mmc: core: Don't export some eMMC specific functions from core.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 8, 2017 at 3:27 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:

> The mmc_start|stop_bkops(), mmc_read_bkops_status() and mmc_interrupt_hpi()
> functions are all used from within the mmc core module, thus there are no
> need to use EXPORT_SYMBOL() for them, so let's remove it.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

> @@ -428,7 +428,6 @@ void mmc_start_bkops(struct mmc_card *card, bool from_exception)
>  out:
>         mmc_release_host(card->host);
>  }
> -EXPORT_SYMBOL(mmc_start_bkops);

For this one, you can also mark it static, and remove the prototype in
mmc_ops.h.

It is only called from inside the same file!

>  int mmc_read_bkops_status(struct mmc_card *card)
>  {
> @@ -887,7 +884,6 @@ int mmc_read_bkops_status(struct mmc_card *card)
>         kfree(ext_csd);
>         return 0;
>  }
> -EXPORT_SYMBOL(mmc_read_bkops_status);

Same for this, but you may have to move the function above
the call site so it compiles.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux