RE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Masahiro Yamada [mailto:yamada.masahiro@xxxxxxxxxxxxx]
> Sent: 17 March, 2017 6:24 PM
> Subject: Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration
> 
> 
> 
> > @@ -62,10 +66,33 @@
> >   */
> >  #define SDHCI_CDNS_MAX_TUNING_LOOP     40
> >
> > +static const struct of_device_id sdhci_cdns_match[];
> > +
> 
> You forgot to remove this.
> 
You are right. Thanks.
 
> 
> > @@ -227,6 +267,7 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
> >         struct sdhci_cdns_priv *priv;
> >         struct clk *clk;
> >         int ret;
> > +       struct device *dev = &pdev->dev;
> >
> >         clk = devm_clk_get(&pdev->dev, NULL);
> 
> 
> If you add "dev", please use it for devm_clk_get, too.
> 
I did on the first patch version but Ulf pointed that this is unrelated change and should be removed. 
Therefore I remove it. 

> 
> 
> --
> Best Regards
> Masahiro Yamada
��.n��������+%������w��{.n�����{��i��)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux