Hi Piotr, 2017-03-17 21:41 GMT+09:00 Piotr Sroka <piotrs@xxxxxxxxxxx>: > DTS properties are used instead of fixed data > because PHY settings can be different for different chips/boards. > > Signed-off-by: Piotr Sroka <piotrs@xxxxxxxxxxx> > --- > Changes for v2: > - dts part was removed from this patch > - most delays were moved from dts file > to data associated with an SoC specific compatible > - remove unrelated changes > --- > Changes for v3: > - move all delays back to dts because they are also boards dependent > - prefix all of the Cadence-specific properties with cdns prefix > - put checking delay properties inside the for loop > instead of using a lot of single if expressions I am OK with this approach because I do not have a better idea. Only two minor comments below. > @@ -62,10 +66,33 @@ > */ > #define SDHCI_CDNS_MAX_TUNING_LOOP 40 > > +static const struct of_device_id sdhci_cdns_match[]; > + You forgot to remove this. > @@ -227,6 +267,7 @@ static int sdhci_cdns_probe(struct platform_device *pdev) > struct sdhci_cdns_priv *priv; > struct clk *clk; > int ret; > + struct device *dev = &pdev->dev; > > clk = devm_clk_get(&pdev->dev, NULL); If you add "dev", please use it for devm_clk_get, too. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
