Re: [PATCH v4] mmc: sdhci: clarify the get_timeout_clock callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shawn,


>
>> users did that), it's more nature to return the value in Hz and we
>
> nature -> natural
>
>> make a explicit comment there. Then we put the unit conversion inside

While you are at it,

a explicit -> an explicit



>> the sdhci core. Thus will improve the code and prevent further misues.
>
> misues -> misuses
>
>>
>> [1]: https://patchwork.kernel.org/patch/9569431/
>
> + blank line
>
>> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
>> Cc: Anssi Hannula <anssi.hannula@xxxxxxxxxx>
>> Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>


When applied, my Cc can be dropped
because I had already given Acked-by.


-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux