On 31 January 2017 at 12:28, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> On 30 January 2017 at 14:26, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>> When retrying to send a request, we used to have a NULL
>> check on the request we try to resend.
>>
>> It was removed in commit
>> c659b878689c ("mmc: block: inline command abortions")
>> but maybe that was not such a good idea. Maybe it can
>> actually be NULL?
>>
>> This might be causeing regressions in errorpath behaviour
>> seen in kernelci boot tests on the sunxi.
>>
>> I'm not sure because this state machine has so many
>> entrances and exits that I can't wrap my head around it.
>>
>> Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
>> Reported-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> I have applied this for next. Let's see what kernelci reports from the
> boot test of the sunxi boards.
Seems like this fixed the problem. Kernelci no longer reports issues
for the sunxi boards [1].
Regarding the existing sunxi mmc driver error messages, those are
still there [2].
>
> If it turns out to be a good fix, I am going to fold this change into
> "mmc: block: inline command abortions", but re-writing the changelog
> of that a bit.
>
> Please tell me if you don't think this is a good idea.
>
Folding in this change into "mmc: block: inline command abortions"....
Kind regards
Uffe
[1]
https://kernelci.org/boot/all/job/ulfh/kernel/v4.10-rc6-120-g3e05469d6088/
[2]
https://storage.kernelci.org/ulfh/v4.10-rc6-120-g3e05469d6088/arm-multi_v7_defconfig/lab-baylibre-seattle/boot-sun7i-a20-bananapi.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
