Hi Ulf, On Tue, Jan 24, 2017 at 09:12:07AM +0100, Ulf Hansson wrote: > On 16 January 2017 at 17:56, Maxime Ripard > <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > > The MMC and SD specifications documents that the clock frequency should > > only be changed once gated. > > Where? > > > > > The current code first modifies the parent clock, gates it and then > > modifies the internal divider. This means that since the parent clock rate > > might be changed, the bus clock might be changed as well before it is > > gated, which breaks the specification. > > > > Move the gating before the parent rate modification. > > This all makes perfect sense to me, however I am not sure you need to > refer to the spec to justify these changes. I can't find it anymore :/ I'll resend that patch reworking the commit log. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature
