Re: [PATCH v3 01/15] ARM: pxa: Don't rely on public mmc header to include leds.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Robert Jarzmik <robert.jarzmik@xxxxxxx> writes:

> Ulf Hansson <ulf.hansson@xxxxxxxxxx> writes:
>
>> On 20 January 2017 at 09:01, Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote:
>>> Ulf Hansson <ulf.hansson@xxxxxxxxxx> writes:
>>> So I was wondering how you made the choice of which files you add the include to
>>> and which you don't touch ?
>>
>> By building the pxa_defconfig, see what errors it reports and then fix them.
>>
>> Isn't pxa_defconfig building all the variants?
> Euh actually it should, but it's not.

And actually thanks to a suggestion from Russell to improve my search line, I
came up with the command line bellow, and perhaps you could fix the others with
one command line and respin the patch ?

Here it is :

for f in $(grep -l _led arch/arm/mach-pxa/*.c | xargs grep -L linux/leds.h); do
sed -i '0,/^#include <linux\/[l-m].*>$/{s/\(#include <linux\/[l-m].*\)/#include
<linux\/leds.h>\n\1/}' $f; done

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux