On 20 January 2017 at 09:01, Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote: > Ulf Hansson <ulf.hansson@xxxxxxxxxx> writes: > >> Some of the pxa platforms, balloon3, colibri-pxa270-income, corgi, >> trizeps4, vpac270, zeus and zylonite depends on leds.h. Explicitly include >> it instead of relying on the public mmc header host.h. >> >> Cc: Daniel Mack <daniel@xxxxxxxxxx> >> Cc: Haojian Zhuang <haojian.zhuang@xxxxxxxxx> >> Cc: Robert Jarzmik <robert.jarzmik@xxxxxxx> >> Cc: <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx> >> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> >> --- >> >> I am seeking an ack for this change as following changes for mmc in the >> series, has build-dependencies to it. > Acked-by: Robert Jarzmik <robert.jarzmik@xxxxxxx> > > Actually I already have a patch for arch/arm/mach-pxa/idp.c which adds this > include also in my -next tree, just in case you're tempted to modify this one, > which would conflict with my pxa tree. > > An other point, I checked which files don't have a leds.h : > - grep -ls _led arch/arm/mach-pxa/*.c > /tmp/a > - grep -ls 'linux/leds.h' arch/arm/mach-pxa/*.c > /tmp/b > - sdiff -s /tmp/a /tmp/b > This gives me : > balloon3.c > colibri-pxa270-income.c > corgi.c > corgi_pm.c > em-x270.c > ezx.c > hx4700.c > magician.c > palmld.c > palmtc.c > palmtreo.c > palmz72.c > spitz_pm.c > tosa.c > trizeps4.c > vpac270.c > z2.c > zeus.c > zylonite.c > zylonite_pxa300.c > zylonite_pxa320.c > > So I was wondering how you made the choice of which files you add the include to > and which you don't touch ? By building the pxa_defconfig, see what errors it reports and then fix them. Isn't pxa_defconfig building all the variants? Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
