On Tue, Jan 10, 2017 at 04:10:52PM +0100, Ulf Hansson wrote: > To validate whether native hotplug needs to be used, the tmio driver checks > whether the mmc->slot.cd_irq has been successfully assigned. > > This check is redundant at its current place in tmio_mmc_host_probe(), as > the mmc core assigns mmc->slot.cd_irq a valid value first when > mmc_gpiod_request_cd_irq() is called. Therefore, let's just remove the > check for now, as that also removes a layering violation of the tmio driver > accessing core specific data via ->slot.cd_irq. > > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> Agreed. This is a layering violation and can be safely removed since it is a no-op currently. Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Besides card eject still works on my M3-W. I will test on my H2 tomorrow or the day after that. Thanks, Wolfram -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
