On 10 January 2017 at 16:10, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > To validate whether native hotplug needs to be used, the tmio driver checks > whether the mmc->slot.cd_irq has been successfully assigned. > > This check is redundant at its current place in tmio_mmc_host_probe(), as > the mmc core assigns mmc->slot.cd_irq a valid value first when > mmc_gpiod_request_cd_irq() is called. Therefore, let's just remove the > check for now, as that also removes a layering violation of the tmio driver > accessing core specific data via ->slot.cd_irq. > > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> I have applied this for next, to get it tested. Wolfram, Simon, please tell if you see any issues! Kind regards Uffe > --- > drivers/mmc/host/tmio_mmc_pio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c > index 3ca97f3..0ef5780 100644 > --- a/drivers/mmc/host/tmio_mmc_pio.c > +++ b/drivers/mmc/host/tmio_mmc_pio.c > @@ -1177,8 +1177,7 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host, > > _host->native_hotplug = !(pdata->flags & TMIO_MMC_USE_GPIO_CD || > mmc->caps & MMC_CAP_NEEDS_POLL || > - !mmc_card_is_removable(mmc) || > - mmc->slot.cd_irq >= 0); > + !mmc_card_is_removable(mmc)); > > /* > * On Gen2+, eMMC with NONREMOVABLE currently fails because native > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
