On 05/01/17 17:27, Shah, Nehal-bakulchandra wrote: > Currently I am focusing on future EMMC Controller for AMD Platform. This > controller is EMMC 5.0 based ACPI device in our system. As I can see the > code in mmc driver sdhci-acpi.c supports acpi enumerated EMMC controller. > As per my understanding I need to update device id for AMD Controller in > sdhci_acpi_uids table and sdhci_acpi_ids table. That apart do I have to > write separate platform driver interface? If yes, what is exactly > required to be done, we have acpi to platform interface file at > drivers\acpi\acpi_apd.c (like lpss of intel) so can we leverage the > same? Also Anything to do related to mmc binding? If your host controller is enumerated by ACPI and follows the SDHCI specification as implemented by drivers/mmc/host/sdhci.c then adding the HID to sdhci_acpi_uids and sdhci_acpi_ids should enable it. Note that sdhci-acpi is a driver for the compatibility ID "PNP0D40" which is used for host controllers that follow the SDHCI specification. That means if your ACPI device node includes _CID of "PNP0D40" then it will already be probed by sdhci-acpi. On the other hand, if your device does not follow SDHCI very well you might be better off avoiding "PNP0D40" and writing your own driver. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html