On Thu, Nov 10, 2016 at 11:51 AM, Alexandre Torgue
<alexandre.torgue@xxxxxx> wrote:
> Hi Andrea,
>
> Some minor remarks.
Hi, thank you for reviewing :)
Also adding Bruno Herrera in CC..
> On 11/08/2016 02:43 PM, Andrea Merello wrote:
>>
>> Signed-off-by: Andrea Merello <andrea.merello@xxxxxxxxx>
>> ---
>> arch/arm/boot/dts/stm32f429.dtsi | 31 +++++++++++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32f429.dtsi
>> b/arch/arm/boot/dts/stm32f429.dtsi
>> index 336ee4f..961bc0c 100644
>> --- a/arch/arm/boot/dts/stm32f429.dtsi
>> +++ b/arch/arm/boot/dts/stm32f429.dtsi
>> @@ -313,6 +313,37 @@
>> };
>> };
>>
>> + sdio_pins:sdio_pins@0 {
>
> Add a space after ":"
OK
>>
>> + pins {
>> + pinmux =
>> <STM32F429_PC8_FUNC_SDIO_D0>,
>> +
>> <STM32F429_PC9_FUNC_SDIO_D1>,
>> +
>> <STM32F429_PC10_FUNC_SDIO_D2>,
>> +
>> <STM32F429_PC11_FUNC_SDIO_D3>,
>> +
>> <STM32F429_PC12_FUNC_SDIO_CK>,
>> +
>> <STM32F429_PD2_FUNC_SDIO_CMD>;
>> + drive-push-pull;
>> + slew-rate = <2>;
>> + };
>> + };
>> +
>> + sdio_pins_od:sdio_pins_od@0 {
>
> same
OK
>>
>> + pins {
>> + pinmux =
>> <STM32F429_PC8_FUNC_SDIO_D0>,
>> +
>> <STM32F429_PC9_FUNC_SDIO_D1>,
>> +
>> <STM32F429_PC10_FUNC_SDIO_D2>,
>> +
>> <STM32F429_PC11_FUNC_SDIO_D3>,
>> +
>> <STM32F429_PC12_FUNC_SDIO_CK>;
>> + drive-push-pull;
>> + slew-rate = <2>;
>> + };
>> +
>> + pins_od {
>> + pinmux =
>> <STM32F429_PD2_FUNC_SDIO_CMD>;
>> + drive-open-drain;
>> + slew-rate = <2>;
>> + };
>
> Why don't use "pins1" and "pins2" instead of "pins" and "pins_od" like it is
> done for usart1?
OK
> regards
> Alex
>
>
>> + };
>> +
>
>
>
>
>
>> ethernet0_mii: mii@0 {
>> pins {
>> pinmux =
>> <STM32F429_PG13_FUNC_ETH_MII_TXD0_ETH_RMII_TXD0>,
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
