On Sun, 9 Oct 2016, Vladimir Zapolskiy wrote:
> Hi Alexander,
>
> On 09.10.2016 18:34, Alexander Kurz wrote:
> > According to the reference manuals, both imx50/imx53 SOC seem to share
> > the same eSDHC controller, especially the section on "Multi-block Read"
> > mentioned in commit 361b8482026c ("mmc: sdhci-esdhc-imx: fix multiblock
> > reads on i.MX53") is identical for both SOC.
> > Hence, let imx50 use imx53-esdhc.
> >
> > Signed-off-by: Alexander Kurz <akurz@xxxxxxxx>
> > ---
> > arch/arm/boot/dts/imx50.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi
> > index e245713..769eac7 100644
> > --- a/arch/arm/boot/dts/imx50.dtsi
> > +++ b/arch/arm/boot/dts/imx50.dtsi
> > @@ -99,7 +99,7 @@
> > ranges;
> >
> > esdhc1: esdhc@50004000 {
> > - compatible = "fsl,imx50-esdhc";
> > + compatible = "fsl,imx50-esdhc", "fsl,imx53-esdhc";
>
> Instead of this change please add "fsl,imx50-esdhc" compatible to a list found in
> drivers/mmc/host/sdhci-esdhc-imx.c
For me it looks like a typical usecase to be handled via DT.
>From the perspective of the reference manuals it looks like both SOC
feature exactly the same sdhc hardware.
Extra benefit: projects sharing the linux DT set (e.g. barebox) will
immediately profit from this change.
>
> Regarding DTS change if the controllers are the same I think it may
> have sense to add "fsl,imx50-esdhc" compatible to imx53.dtsi definitions,
> but not the other way round.
Is there some requirement for ascending numbers?
I guess, i.MX50 just got the smaller number (compared to i.MX51/53) for
marketing reasons (consumer-e-book reader vs "serious" industrial
applications). Also the mx50 is a younger design compared to the mx51.
The mx50 is an SOC for e-book readers and other battery powered gadgets
(e.g. battery powered wireless hard disk) - it never got the attention
like the industrial SOC series (mx51/53).
>
> --
> With best wishes,
> Vladimir
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
