Hey Jaehoon, Jaehoon Chung wrote: > Hi Tobias, > > On 09/19/2016 04:41 PM, Tobias Jakobi wrote: >> Hello Jaehoon, >> >> >> Jaehoon Chung wrote: >>> Hi Tobias, >>> >>> CC'd mmc mailing. >>> >>> On 09/19/2016 10:03 AM, Seung-Woo Kim wrote: >>>> Hello Jaehoon, >>>> >>>> On 2016년 09월 19일 09:32, Jaehoon Chung wrote: >>>>> Hi Tobias, >>>>> >>>>> On 09/16/2016 02:29 AM, Tobias Jakobi wrote: >>>>>> Hello everyone, >>>>>> >>>>>> I'm experiencing massive kernel log spamming by dw_mmc, the commit that >>>>>> causes this is the following one. >>>>>> >>>>>> 65257a0deed5aee66b4e3708944f0be62a64cabc >>>>>> >>>>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=65257a0deed5aee66b4e3708944f0be62a64cabc >>>>>> >>>>>> I've briefly checked the commit and I think the rationale behind >>>>>> removing the check is incorrect. While MMC_CLKGATE was certainly >>>>>> removed, runtime PM has "replaced" it (the commit >>>>>> 9eadcc0581a8ccaf4c2378aa1c193fb164304f1d even mentions this). >>>>>> >>>>>> This is on an Exynos4412 board, kernel is 4.8-rc6. Nothing is connected >>>>>> to the eMMC connector. >>>>> >>>>> Thanks for reporting this. >>>>> >>>>> Seung-Woo, Could you check your patch? I will also check this. >>> >>> Did you test after reverting this commit? or previous version is working fine? >> yes, reverting the commit fixes the log spamming. I'm aware though that >> the check is more of less broken (undefined behaviour because of >> bit-shifting with large values), so I have also tried the following >> thing: Just checking against 'div' instead of 'clock << div'. Anyway, >> this also works for me. >> >> >>> Which exynos4412 board do you use? I think it's related with "broken-cd". >>> (If you can share which board and dts you are using, we can check in more detail.) >> This is an Odroid-X2 board. >> > > When i have checked on odroid-u3, it's reproduced very easy. good to hear! I also worry that I'm the only one with these issues on the X2. :) Anyway, do you seen any other message on the U3 that are related to the eMMC. I'm asking because I have also experience some warning/error from the regulator subsystem: > Sep 15 17:19:56 chidori kernel: [ 4.976690] vddf_emmc_2.85V: voltage operation not allowed > Sep 15 17:19:56 chidori kernel: [ 4.995417] mmc_host mmc1: Bus speed (slot 0) = 50000000Hz (slot req 400000Hz, actual 396825HZ div = 63) I'm sending you a patch shortly which fixes the warning, but I'm not sure if this is the right approach. Maybe you can take a look? >>> As you mentioned, you didn't insert the eMMC card on board. >>> Then it should be polling whether card is inserted/removed. (If broken-cd is set...) >> I can check the callstack leading to dw_mci_setup_bus() I guess. Would >> that should make it easier for you guys to understand where the issue >> originates from? > > Not need to share the callstack. Because i understood what is problem. > But checking 'div' instead of 'clock << div' should also have the unexpected behavior. Why is that? If I understood the initial problem correctly, then shifting with 'div' produces undefined behaviour since we don't know an upper bound for it. That's not the case if we just compare old and new divisor. > If needs to fix, i want to go ahead the correct way at this time. > Anyway, thanks for reporting this! Also thanks, and let me know if I can test anything else. With best wishes, Tobias > Best Regards, > Jaehoon Chung > >> >> >>> I think it's not related with runtime PM. >>> >>> Best Regards, >>> Jaehoon Chung >> >> WIth best wishes, >> Tobias >> >> >> >> >>>> Ok, I will check on Exynos4412 SpC boards. >>>> >>>> By the way, to check no condition case, when I posted after v2[1], I >>>> checked with Exynos5422 and Exynos5433 SoC boards and they didn't show >>>> duplicated log, so I agreed not to check condition for logging. >>>> >>>> [1] https://patchwork.kernel.org/patch/9182469/ >>>> >>>> Best Regards, >>>> - Seung-Woo Kim >>>> >>>>> >>>>> Best Regards, >>>>> Jaehoon Chung >>>>> >>>>>> >>>>>> With best wishes, >>>>>> Tobias >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>> >>> >> >> >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
