On 04/21/2016 11:52 AM, Arnd Bergmann wrote:
On Thursday 21 April 2016 10:26:55 Lars Persson wrote:
It is a common pattern in all upstream mmc drivers to not make the call
to mmc_regulator_set_vqmmc() when a regulator is missing. We basically
want to log errors except for the EINVAL returned in case of a missing
regulator.
I see what you mean here: two out of four drivers calling
mmc_regulator_set_vqmmc() log errors to the console.
If we want all drivers to behave consistently here, how about
moving that error output into the mmc_regulator_set_vqmmc() function
itself?
I will make a v4 that skips the error output and if Ulf agrees with your
proposal I will make another patch series to move the dev_dbg() into
mmc_regulator_set_vqmmc().
- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
