Re: [PATCH 2/2] mmc: mvsdio: delete platform data code path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 25, 2015 at 4:02 PM, Andrew Lunn <andrew@xxxxxxx> wrote:
> On Wed, Nov 25, 2015 at 02:57:57PM +0100, Linus Walleij wrote:
>> There are no in-kernel users of the MVSDIO platform data method
>> (instantiating from a board file) so just delete this code and
>> make this a DT-only driver. We depend on OF and check that we have
>> an OF node in probe().
>>
>> Cc: Nicolas Pitre <nico@xxxxxxxxxxx>
>> Cc: Andrew Lunn <andrew@xxxxxxx>
>> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Looks good. I guess i would of reversed the order of these two patches
> so you don't first add struct mvsdio_platform_data to the driver and
> then remove it, but that is a minor nit pick.
>
> Acked-by: Andrew Lunn <andrew@xxxxxxx>

Ulf can just squash them if he likes, that'd do it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux